Re: [PATCH 03/19] test: Cleanup exit/failure paths of some storage pool APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/11/2017 04:33 AM, Pavel Hrdina wrote:
> On Tue, May 09, 2017 at 11:30:10AM -0400, John Ferlan wrote:
>> Rework some of the test driver API's to remove the need to return failure
>> when testStoragePoolObjFindByName returns NULL rather than going to cleanup.
>> This removes the need for check for "if (obj)" and in some instances the
>> need to for a cleanup label and a local ret variable.
> 
> The recommended wrapping of commit message body is 72 columns.
> 

I must violate that a lot ;-)

I adjusted...

John

>> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
>> ---
>>  src/test/test_driver.c | 49 ++++++++++++++++---------------------------------
>>  1 file changed, 16 insertions(+), 33 deletions(-)
> 
> Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux