On Sun, Jul 02, 2017 at 04:16:02AM +0200, Marek Marczykowski-Górecki wrote: > On Sun, Feb 26, 2017 at 07:02:24PM -0700, Jim Fehlig wrote: > > Long ago danpb posted some patches to test libvirt domXML to > > libxl_domain_config conversion > > > > https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html > > > > Some of the prerequisite patches were pushed, but we've never managed > > to push patches actually providing the conversion tests. I sent several > > follow-ups to Dan's work but never converged on a satisfactory solution > > for all the Xen versions supported by libvirt. The last attempt was in > > Sept 2014 > > > > https://www.redhat.com/archives/libvir-list/2014-September/msg00698.html > > > > I tried to revive the work in Jan 2015, but that also stalled > > > > https://www.redhat.com/archives/libvir-list/2015-January/msg00924.html > > > > Fast-forward over 2.5 years from the first attempt and libvirt no longer > > supports older Xen versions 4.2 and 4.3 that were proving to be problematic. > > Starting with Xen 4.5 libxl added support for libxl_domain_config_from_json, > > which provides a way to implement the conversion tests that work with all > > Xen versions >= 4.5 (including latest xen.git master). > > Few more months have passed... > > FWIW, I've tested it with Xen 4.6. The patch needs very minor update: > - s/VIRT_TEST_MAIN_PRELOAD/VIR_TEST_MAIN_PRELOAD/ > - add xencaps argument to libxlBuildDomainConfig call > > After that, it works! When I made some test to fail, reported error is > not so helpful ("libvirt: Xen Light Driver error : internal error: > Expected and actual libxl_domain_config objects do not compare"), but it > do catch failures. > Then, if I change strcmp to virTestCompareToString, the output is much > more helpful. > > I'd really love to have it merged, mostly because I want to add more tests > using this framework (see "Add setting CPU features (CPUID) with > libxenlight driver" thread). > Is there anything I can do to make it happen? Ping? -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
