On 06/02/2017 12:25 PM, John Ferlan wrote: > Modify the virNWFilterObjNew to take @def as a parameter and consume it. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/conf/virnwfilterobj.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) As I've stated in the other review for secret patch set, I don't see much value in this patch. What your reasoning for it? We don't usually do it this way. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list