On 7/12/17 2:49 AM, Peter Krempa wrote: > On Tue, Jul 11, 2017 at 21:33:49 -0600, Liang Yan wrote: >> It may be better to check virtio-scsi controller first since it is >> supported better in qemu level. > This is not true for OS support. The old controller usually has drivers > shipped with the system, whereas you need to install drivers separately > for virtio-scsi. That is fair, I only thought limited distro this time, my bad, :) We do have some issues recently that attach passthrough lun device could work well with virtio-scsi controller but not lsi controller, we thought it may be better to set a specif controller for "attach-disk" here, what do you say? Do you think is it necessary to add an extra parameter or just fine-grain support for "-targetbus" that could support specific type? or another solution that I missed? I would be glad to implement it. Thanks so much for your response. Best, Liang > I don't think we can change the default easily. > > NACK > >> >> Signed-off-by: Liang Yan<lyan@xxxxxxxx> > Your signoff line does not have a space betweent the name and address. > >> --- >> src/qemu/qemu_domain_address.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-)
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
