Our documentation provides them, so the helper should return them. --- src/util/virstoragefile.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index cae20eccc..0c215e1b6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -4049,11 +4049,15 @@ virStorageSourceNetworkDefaultPort(virStorageNetProtocol protocol) return "22"; case VIR_STORAGE_NET_PROTOCOL_ISCSI: + return "3260"; + case VIR_STORAGE_NET_PROTOCOL_GLUSTER: - /* no default port specified */ - return "0"; + return "24007"; case VIR_STORAGE_NET_PROTOCOL_RBD: + /* we don't provide a default for RBD */ + return NULL; + case VIR_STORAGE_NET_PROTOCOL_LAST: case VIR_STORAGE_NET_PROTOCOL_NONE: return NULL; -- 2.12.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list