On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote: > @@ -1877,8 +1877,8 @@ qemuProcessMonitorReportLogError(qemuMonitorPtr mon ATTRIBUTE_UNUSED, > > > static int > -qemuProcessLookupPTYs(virDomainDefPtr def, > - virQEMUCapsPtr qemuCaps, > +qemuProcessLookupPTYs(virDomainDefPtr def ATTRIBUTE_UNUSED, > + virQEMUCapsPtr qemuCaps ATTRIBUTE_UNUSED, > virDomainChrDefPtr *devices, > int count, > virHashTablePtr info) I don't see a reason to turn these into ATTRIBUTE_UNUSED, just update the callers and get rid of them entirely. Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list