Re: [PATCH 11/12] qemu: command: support -chardev for platform devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
> @@ -1877,8 +1877,8 @@ qemuProcessMonitorReportLogError(qemuMonitorPtr mon ATTRIBUTE_UNUSED,
>  
>  
>  static int
> -qemuProcessLookupPTYs(virDomainDefPtr def,
> -                      virQEMUCapsPtr qemuCaps,
> +qemuProcessLookupPTYs(virDomainDefPtr def ATTRIBUTE_UNUSED,
> +                      virQEMUCapsPtr qemuCaps ATTRIBUTE_UNUSED,
>                        virDomainChrDefPtr *devices,
>                        int count,
>                        virHashTablePtr info)

I don't see a reason to turn these into ATTRIBUTE_UNUSED,
just update the callers and get rid of them entirely.


Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux