Re: [PATCH 5/6] qemu: Use storage driver APIs in qemuDomainBlockPeek

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/23/2017 09:33 AM, Peter Krempa wrote:
> Refactor the access to storage driver usage along with
> qemuDomainStorageFileInit which ensures that we access the file with
> correct DAC uid/gid.
> ---
>  src/qemu/qemu_driver.c | 25 ++++++++-----------------
>  1 file changed, 8 insertions(+), 17 deletions(-)
> 

Irony is the comment at the end of qemuOpenFile:

 * This function should not be used on storage sources. Use
 * qemuDomainStorageFileInit and storage driver APIs if possible.

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux