On 06/23/2017 09:33 AM, Peter Krempa wrote: > Refactor the access to storage driver usage along with > qemuDomainStorageFileInit which ensures that we access the file with > correct DAC uid/gid. > --- > src/qemu/qemu_driver.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) > Irony is the comment at the end of qemuOpenFile: * This function should not be used on storage sources. Use * qemuDomainStorageFileInit and storage driver APIs if possible. Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list