On Fri, Jun 30, 2017 at 05:45:04PM +0200, Andrea Bolognani wrote: > On Fri, 2017-06-30 at 14:19 +0100, Daniel P. Berrange wrote: > > > > Not all builders run all jobs, eg. the test suite is skipped > > > > on FreeBSD, but they all at least compile the library. > > > > > > Is there any specific reason why it doesn't run test suite on FreeBSD? > > > Generally, '(g)make check' should run fine, with the only exception that > > > virnetsockettest fails from time to time (maybe once in 4-5 runs). > > qemuxml2argvtest fails consistently in my FreeBSD guest. > > virnetsockettest also fails pretty often for me, certainly > more than your figure; even if that wasn't the case, 1/5 > failure rate is way too high for a CI job. > > > > 'syntax-check' will not work without local hacks though because it hits > > > argmax limit that results in 'argument list too long' for a lot of > > > checks. > > > > Our 'check' jobs depend on the 'syntax-check' jobs as a pre-requisite, > > so its fallout from not running syntax-check on BSD > > Can we invert the dependency so that syntax-check requires > check instead? I think we could actually just let them run in parallel, and then make the rpm job depend on both Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
