On Fri, Jun 30, 2017 at 10:44:39 +0200, Peter Krempa wrote:
> On Thu, Jun 29, 2017 at 19:02:41 -0700, Ashish Mittal wrote:
> > From: Ashish Mittal <ashish.mittal@xxxxxxxxxxx>
[...]
> > diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> > index 7525a2a..909af50 100644
> > --- a/docs/schemas/domaincommon.rng
> > +++ b/docs/schemas/domaincommon.rng
> > @@ -1622,6 +1622,11 @@
> > </attribute>
> > <attribute name="name"/>
> > <ref name="diskSourceNetworkHost"/>
> > + <optional>
> > + <attribute name="tls">
> > + <ref name="virYesNo"/>
> > + </attribute>
>
> Make this a definition for future reuse. Additionally I think that the
> TLS part should be a separate element here. Something like
>
> <disk>
> <source>
I forgot to finish my thought before sending. I think we want a separate
element with an attribute at this point. This allows adding other TLS
related stuff to it if such need arises.
<disk type='network' device='disk'>
<driver name='qemu' type='raw' cache='none'/>
<source protocol='vxhs' name='eb90327c-8302-4725-9e1b-4e85ed4dc251'>
<host name='192.168.0.1' port='9999'/>
<tls enabled='yes'/>
</source>
[...]
</disk>
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
