On 06/29/2017 07:17 AM, Andrea Bolognani wrote: > On Wed, 2017-06-28 at 15:30 -0400, John Ferlan wrote: >> Keep line length <= 80 cols. >> >> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> >> --- >> src/qemu/qemu_conf.c | 93 ++++++++++++++++++++++++++++++++++------------------ >> 1 file changed, 62 insertions(+), 31 deletions(-) > > I'm pretty sure we agreed that the 80 column limit is not > something we're interested in enforcing: if anything, we're > actually moving away from it when changing existing code. > > -- > Andrea Bolognani / Red Hat / Virtualization > The collective "we"? Not sure I agree. I was under the impression that it wasn't a requirement to change existing code to wrap at 80 cols, rather it was something that one could do and if they did so it should be a separate patch rather than interspersing within other changes. I think if it's one or two characters, then it's not such a huge deal, but having long lines that wrap in code is unreadable especially for those of us using 80xNN windows. Those that use 100xNN or 132xNN with 8pt fonts will eventually need an 80xNN window with 18pt fonts ;-). Still, I'm not really interested in a long debate on this, so I can drop this patch even though I find the code to be unreadable as is. John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
