On Wed, 2017-06-28 at 13:32 -0400, Laine Stump wrote: > > Isolation groups will eventually allow us to make sure certain > > devices, eg. PCI hostdevs, are assigned to guest PCI buses in > > a way that guarantees improved isolation, error detection and > > recovery for machine types and hypervisors that support it, > > eg. pSeries guest on QEMU. > > This is a nice introduction of what isolation groups will do, but > doesn't really explain what this patch does. As I understand it, it is > just adding the isolation group to virDomainDeviceInfo (so that each > device can have an isolation group associated with it) and to > virDomainPCIAddressBus (so that each bus can have an isolation group), > then adds an isolationGroup arg (so far unused) to all the PCI address > allocation functions - presumably the next couple patches will fill in > the hypervisor-specific logic to request a particular isolation group > when desired, and the logic in the allocator to honor those requests. > > That all makes sense to me. That's correct: this first patch merely defines storage for the new information we're going to need later on and makes sure it is passed between the QEMU (or bhyve) driver and PCI address allocation code. I'll add this information to the commit message. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list