On 06/22/2017 12:18 PM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1462060 > > Just like in the previous commit, when attaching a file based > device which has its source living under /dev (that is not a > device rather than a regular file), calling mknod() is no help. > We need to: > > 1) bind mount device to some temporary location > 2) enter the namespace > 3) move the mount point to desired place > 4) umount it in the parent namespace from the temporary location > > At the same time, the check in qemuDomainNamespaceSetupDisk makes > no longer sense. Therefore remove it. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 59 ++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 48 insertions(+), 11 deletions(-) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John I have the same !isLink comment as last patch, but I see it's even more prevalent now so I guess it's fine the way it is... -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
