On 06/23/2017 11:03 AM, Andrea Bolognani wrote:
> Adding it to the virDomainControllerPCIModelName enumeration
> is enough for existing code to handle it, so parsing and
> formatting will work without further tweaking.
>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
Reviewed-by: Laine Stump <laine@xxxxxxxxx>
(assuming you document it in one of these other patches)
> ---
> docs/schemas/domaincommon.rng | 2 ++
> src/conf/domain_conf.c | 1 +
> src/conf/domain_conf.h | 1 +
> 3 files changed, 4 insertions(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 39eff46..73343a5 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -1954,6 +1954,8 @@
> <element name="model">
> <attribute name="name">
> <choice>
> + <!-- implementations of 'pci-root' -->
> + <value>spapr-pci-host-bridge</value>
> <!-- implementations of 'pci-bridge' -->
> <value>pci-bridge</value>
> <!-- implementations of 'dmi-to-pci-bridge' -->
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 1538747..6afcbe7 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -349,6 +349,7 @@ VIR_ENUM_IMPL(virDomainControllerPCIModelName,
> "pxb",
> "pxb-pcie",
> "pcie-root-port",
> + "spapr-pci-host-bridge",
> );
>
> VIR_ENUM_IMPL(virDomainControllerModelSCSI, VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LAST,
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 53a10db..b3699e7 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -710,6 +710,7 @@ typedef enum {
> VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PXB,
> VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PXB_PCIE,
> VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_PCIE_ROOT_PORT,
> + VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_SPAPR_PCI_HOST_BRIDGE,
>
> VIR_DOMAIN_CONTROLLER_PCI_MODEL_NAME_LAST
> } virDomainControllerPCIModelName;
>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
