Re: [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

[Eli Qiao <qiaoliyong@xxxxxxxxx>]

On Thursday, 22 June 2017 at 8:41 PM, Martin Kletzander wrote:

I missed this. Ye, you're right, thanks for showing that with a use

case. We could then require only the cache_id and automatically fill

in level and type. Migration (or rather any start) should then fail if

that cache_id doesn't correspond to the level and type requested. I

still can't find a reason for 'id', though.

I agree that id, level is useless, but also type is required, the case is when

host’s enabled CDP like this:

      <bank id='0' level='3' type='both' size='15360' unit='KiB' cpus='0-5'>

        <control granularity='768' unit='KiB' type='code' maxAllocs='8'/>

        <control granularity='768' unit='KiB' type='data' maxAllocs='8'/>

      </bank>

the cachetune need to be defined as:

<cachetune cache_id='0' type=‘l3data' size='2816' unit='KiB' vcpus=‘0,1’/>

<cachetune cache_id='0' type=‘l3code' size='2816' unit='KiB' vcpus=‘0,1’/>

<cachetune cache_id=‘1' type=‘l3data' size='2816' unit='KiB' vcpus=‘2,3’/>

<cachetune cache_id=‘1' type=‘l3code' size='2816' unit='KiB' vcpus=’2,3’/>

Thought?

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list