On Tuesday, 20 June 2017 at 8:39 PM, Martin Kletzander wrote:
On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote:This patch adds 3 major private interface.virResctrlGetFreeCache: return free cache, default cache substract cacheallocated.virResctrlSetCachetunes: set cache banks which defined in a domain.virResctrlRemoveCachetunes: remove cache allocation group from thehost.There's some existed issue when do syntax-check as I reference the cachetune and cachebank definition (from conf/domain_conf.h) inutil/virresctrl.h.
Yes, util/ cannot depend on conf/ in libvirt due to various reasons.All the data you want to use in util/ need to be defined there. If thatcorresponds to some XML, the parsers and formatters must be in conf/.In rare cases, there might be need for two data structures, one in util/and one in conf/. I don't think that's needed in this case.
I can move the virDomainCacheBank definition to util/virresctrl.h
but what about the virCapsHostPtr, we need the host cache information and resctrl information
it’s defined in src/conf/capabilities.h”
Do we need to define another copy in virresctrl.h ?
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
