John Ferlan wrote: > > > On 05/09/2017 07:54 AM, Roman Bogorodskiy wrote: > > Connect domain XML <driver vgaconf=""> configuration (introduced in a > > previous patch) to bhyve command generation. > > > > Unfortunately, this option was documented just recently and at the time > > of writing official online manpages didn't have it updated, so for now > > one can refer to: > > > > https://github.com/freebsd/freebsd/blob/master/usr.sbin/bhyve/bhyve.8#L327 > > > > for the detailed description of the possible vga configuration options. > > > > Also, add some tests for this new feature. > > > > Signed-off-by: Roman Bogorodskiy <bogorodskiy@xxxxxxxxx> > > --- > > src/bhyve/bhyve_command.c | 4 ++ > > .../bhyvexml2argv-vnc-vgaconf.args | 12 ++++++ > > .../bhyvexml2argv-vnc-vgaconf.ldargs | 1 + > > .../bhyvexml2argv-vnc-vgaconf.xml | 31 ++++++++++++++++ > > tests/bhyvexml2argvtest.c | 1 + > > .../bhyvexml2xmlout-vnc-vgaconf.xml | 43 ++++++++++++++++++++++ > > tests/bhyvexml2xmltest.c | 1 + > > 7 files changed, 93 insertions(+) > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.args > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.ldargs > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-vnc-vgaconf.xml > > create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-vnc-vgaconf.xml > > > > As noted previously the xml2xml would be better served in the other > patch. The rest seems reasonable, but obviously is affected by the other > one... Still wanted to be sure to respond so that it's not left hanging > without a response. Good, I'll squash these two commits into a single one. Roman Bogorodskiy
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
