On Fri, Jul 10, 2009 at 06:17:34PM +0200, Paolo Bonzini wrote:
> This patch uses a stop/migrate/cont combination to implement
> "virsh dump" for QEMU guests (BZ507551).
>
> The code is mostly based on qemudDomainSave, except that the XML
> prolog is not included as it is not needed to examine the dump
> with e.g. crash.
>
> The plan is to implement live dumping in the future. When that is
> done, it shouldn't require reindentation. This plan is also the
> reason for the "weird"
>
> resume = (vm->state == VIR_DOMAIN_RUNNING);
> if (vm->state == VIR_DOMAIN_RUNNING) {
> ...
> }
>
> * src/qemu_driver.c (qemudDomainCoreDump): New.
> (qemuDriver): Add core dump function.
> ---
> The virsh dump for xen does not crash the VM, and so does
> this KVM implementation.
Looks fine to me at this point ACK,
For the subsequent patch adding live and crash options, that will need
to modify include/libvirt/libvirt.h.in , then the two back-end of xen
and qemu.
Thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list