On 06/07/2017 05:51 PM, Jim Fehlig wrote: > On 06/06/2017 06:53 AM, Michal Privoznik wrote: >> While reworking client side of streams, I had to postpone payload >> decoding so that stream holes and stream data can be >> distinguished in virNetClientStreamRecvPacket. That's merely what >> 18944b7aea46d does. However, I accidentally removed one important >> bit: when server sends us an empty STREAM packet (with no >> payload) - meaning end of stream - st->incomingEOF flag needs to >> be set. It used to be before I touched the code. After I removed >> it, virNetClientStreamRecvPacket will try to fetch more data from >> the stream, but it will never come. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> >> Thanks to Martin who helped me debug this. >> >> src/rpc/virnetclientstream.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> > Reviewed-by: Jim Fehlig <jfehlig@xxxxxxxx> > > Regards, > Jim > Thank you. Pushed now. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
