On Mon, 2017-06-05 at 15:23 +0100, Daniel P. Berrange wrote: > On Tue, May 30, 2017 at 09:32:43PM +0200, Cédric Bosdonnat wrote: > > When running an application container, setting environment variables > > could be important. > > > > The newly introduced <initenv> tag in domain configuration will allow > > setting environment variables to the init program. > > --- > > docs/formatdomain.html.in | 5 +++++ > > docs/schemas/domaincommon.rng | 10 ++++++++++ > > src/conf/domain_conf.c | 38 ++++++++++++++++++++++++++++++++++++ > > src/conf/domain_conf.h | 8 ++++++++ > > src/lxc/lxc_container.c | 5 +++++ > > tests/lxcxml2xmldata/lxc-initenv.xml | 30 ++++++++++++++++++++++++++++ > > tests/lxcxml2xmltest.c | 1 + > > 7 files changed, 97 insertions(+) > > create mode 100644 tests/lxcxml2xmldata/lxc-initenv.xml > > Generally looks fine, but do we need to wire this up for native-to-xml > conversion too ? lxc config file doesn't have anything related to the command to run, it's env variables and PWD. These will need to be added in docker's json native-to-xml though. -- Cedric -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
