Daniel P. Berrange wrote: > On Fri, Jul 10, 2009 at 04:46:59PM -0400, Cole Robinson wrote: >> We do support allocation progress now, so have the code accomodate. >> --- >> src/storage_backend_fs.c | 49 +++++++++++++++------------------------------- >> 1 files changed, 16 insertions(+), 33 deletions(-) > > Do later patches have a dependancy on this ? > > The allocation progress tracking you mention is actually WRT to > a 2nd thread calling virStorageVolGetInfo while the first thread > is doing the work. AFAIK, that would not be impacted by either > of these 2 code paths. The 'track_allocation_progress' variable > was a placeholder for the case where we do proper async non-blocking > vol creation from a single thread. > > By switching this code to use the iterative allocation, it will > increase the number of ext4 extents required for large files > which is not so desirable. So I think its better to just leave > this code in as is, or remove the other code path. > This change was just a (attempted) cleanup. I'll drop it. Thanks, Cole -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list