Re: [PATCH 0/8] Multiple cleanups within interfaceobj and interface driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/26/2017 12:36 AM, John Ferlan wrote:
> Sensing a theme lately yet?
> 
> More adjustments in preparation for having virobject code handle the bulk
> of the object management code.
> 
> Far less in this series than the other two... The Clone code was a bit
> unique and required more of a rewrite than a refigure since now we have
> two allocated lists rather than two static lists.
> 
> John Ferlan (8):
>   interface: Consistently use 'obj' for a virInterfaceObjPtr
>   interface: Remove some unnecessary goto's for Interface tests
>   interface: Use virInterfaceDefPtr rather than deref from
>     virInterfaceObjPtr
>   interface: Make _virInterfaceObj struct private
>   interface: Make _virInterfaceObjList struct private
>   interface: Rename some virInterfaceObj* API's
>   interface: Clean up virInterfaceObjListFindByMACString
>   interface: Introduce virInterfaceObjNew
> 
>  src/conf/virinterfaceobj.c | 232 +++++++++++++++++++++++++++++----------------
>  src/conf/virinterfaceobj.h |  65 ++++++-------
>  src/libvirt_private.syms   |  15 +--
>  src/test/test_driver.c     | 143 ++++++++++++++--------------
>  4 files changed, 262 insertions(+), 193 deletions(-)
> 

I'm tempted to ACK this, however, patch 8/8 stopped me. I think that if
we are doing this, we can finally turn virInterfaceObj into virObject.

ACK to the rest though.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux