On Thu, May 18, 2017 at 15:46:44 +0200, Michal Privoznik wrote:
> Some older systems (such as RHEL6) lack SEEK_HOLE and SEEK_DATA
> which virFileInData relies on. Provide a stub for these systems.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> configure.ac | 5 +++++
> src/util/virfile.c | 15 +++++++++++++++
> 2 files changed, 20 insertions(+)
[...]
> @@ -3904,6 +3905,20 @@ virFileInData(int fd,
> return ret;
> }
>
> +#else /* !HAVE_DECL_SEEK_HOLE */
> +
> +int
> +virFileInData(int fd ATTRIBUTE_UNUSED,
> + int *inData ATTRIBUTE_UNUSED,
> + long long *length ATTRIBUTE_UNUSED)
> +{
> + virReportSystemError(ENOSYS, "%s",
> + _("sparse files not supported"));
> + return -1;
Wouldn't it be better as a fallback always return that data is present
rather than failing?
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
