Re: [PATCH] test-wrap-argv.pl: Accept short parameter -i for --in-place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 12, 2017 at 04:12:06PM +0200, Pavel Hrdina wrote:
On Fri, May 12, 2017 at 03:59:46PM +0200, Martin Kletzander wrote:
On Fri, May 12, 2017 at 03:15:58PM +0200, Pavel Hrdina wrote:
>On Fri, May 12, 2017 at 03:11:27PM +0200, Martin Kletzander wrote:
>> I like to use it that way and every time I try running it I just
>> instinctively use '-i' (like with sed, etc.) and it makes sense, IMHO.
>>
>> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
>> ---
>>  tests/test-wrap-argv.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Does that mean ACK?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#reviewer-s-statement-of-oversight

s/kernel/libvirt/ for the text


Honestly, I didn't know there is also definition of other -by:'s, I
probably read those docs back when there was just Signed-of-by
definition.  So thanks for new info ;)  Anyway, do we have some
documentation about libvirt using these tags as well?  I only remember
talking about S-o-b being "preferred", not even required.  Any news on
that front?  BTW: I'll push this in a while.

Pavel

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux