Re: [PATCHv4 3/6] conf: add <driver intremap> to <iommu>

[John Ferlan <jferlan@xxxxxxxxxx>]

On 05/03/2017 10:05 AM, Ján Tomko wrote:
> Add a new attribute to control interrupt remapping.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1427005
> ---
>  docs/formatdomain.html.in                          | 24 +++++++++++++-
>  docs/schemas/domaincommon.rng                      |  9 +++++
>  src/conf/domain_conf.c                             | 38 +++++++++++++++++++---
>  src/conf/domain_conf.h                             |  1 +
>  .../qemuxml2argv-intel-iommu-ioapic.xml            |  4 ++-
>  5 files changed, 70 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 6669e71..ca98f0e 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -7395,7 +7395,9 @@ qemu-kvm -net nic,model=? /dev/null
>  <pre>
>  ...
>  &lt;devices&gt;
> -  &lt;iommu model='intel'/&gt;
> +  &lt;iommu model='intel'&gt;
> +    &lt;driver intremap='on'/&gt;
> +  &lt;/iommu&gt;
>  &lt;/devices&gt;
>  ...
>  </pre>
> @@ -7406,6 +7408,26 @@ qemu-kvm -net nic,model=? /dev/null
>            Currently only the <code>intel</code> model is supported.
>          </p>
>        </dd>
> +      <dt><code>driver</code></dt>
> +      <dd>
> +        <p>
> +          The <code>driver</code> subelement can be used to configure
> +          additional options:
> +        </p>
> +        <dl>
> +          <dt><code>intremap</code></dt>
> +          <dd>
> +            <p>
> +              The <code>intremap</code> attribute with possible values
> +              <code>on</code> and <code>off</code> can be used to
> +              turn on interrupt remapping, a part of the VT-d functionality.
> +              Currently this requires split I/O APIC
> +              (<code>&lt;ioapic driver='qemu'/&gt;</code>)

s/)/).

<pesky period>

> +              <span class="since">Since 3.4.0</span> (QEMU/KVM only)
> +            </p>
> +          </dd>
> +        </dl>
> +      </dd>
>      </dl>
>  
>      <h3><a name="seclabel">Security label</a></h3>

[...]

ACK w/ .

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list