On Thu, May 04, 2017 at 13:32:35 +0200, Erik Skultety wrote:
> This patch fixes the following MinGW error (although actually being a
> false positive):
>
> ../../src/util/virmdev.c: In function 'virMediatedDeviceListMarkDevices':
> ../../src/util/virmdev.c:453:21: error: potential null pointer
> dereference [-Werror=null-dereference]
> const char *mdev_path = mdev->path;
> ^~~~~~~~~
>
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
> Pushed under the build breaker rule.
>
> Erik
>
> src/util/virmdev.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/virmdev.c b/src/util/virmdev.c
> index c861d21..174f48c 100644
> --- a/src/util/virmdev.c
> +++ b/src/util/virmdev.c
> @@ -449,9 +449,13 @@ virMediatedDeviceListMarkDevices(virMediatedDeviceListPtr dst,
>
> virObjectLock(dst);
> for (i = 0; i < count; i++) {
> + const char *mdev_path = NULL;
> virMediatedDevicePtr mdev = virMediatedDeviceListGet(src, i);
This does not set an error, ...
> - const char *mdev_path = mdev->path;
>
> + if (!mdev)
> + goto cleanup;
so this function will sometimes report an error and sometimes will not.
> +
> + mdev_path = mdev->path;
> if (virMediatedDeviceIsUsed(mdev, dst) ||
> virMediatedDeviceSetUsedBy(mdev, drvname, domname) < 0)
E.g.: Both of these report an error.
> goto cleanup;
> --
> 2.9.3
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
