Re: [PATCH v2 0/5] add support for qemu-xhci USB controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-04-27 at 20:47 +0200, Andrea Bolognani wrote:
> > Pavel Hrdina (5):
> >    qemu: change the logic of setting default USB controller
> >    qemu: use nec-usb-xhci as a default controller for aarch64 if
> >      available
> >    qemu: introduce QEMU_CAPS_DEVICE_QEMU_XHCI
> >    qemu: add support for qemu-xhci USB controller
> >    qemu: use qemu-xhci USB controller by default for ppc64 and aarch64
> 
> There are a couple of minor nits in patches 4 and 5, the
> kind that would not generally require a respin. The issue
> with patch 1 is also simple enough to be fixed without
> going through another round of reviews, but I'd prefer if
> you dropped that patch altogether and if you decide to do
> so the changes would become significant enough that I
> feel a respin would be warranted.
> 
> Having expressed my preference, I leave up to you how to
> go about dealing with patch 1: you can expect a swift
> response on my part regardless of whether you ask for a
> formal ACK or a review of v3 :)

Given your follow-up comments: after you address the nit
I pointed out in patch 5, you can consider the series

Acked-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux