Re: [PATCH] qemu: Don't fail if physical size can't be updated in qemuDomainGetBlockInfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/20/2017 09:50 AM, Peter Krempa wrote:
> Since commit c5f6151390 qemuDomainBlockInfo tries to update the
> "physical" storage size for all network storage and not only block
> devices.
> 
> Since the storage driver APIs to do this are not implemented for certain
> storage types (RBD, iSCSI, ...) the code would fail to retrieve any data
> since the failure of qemuDomainStorageUpdatePhysical is fatal.
> 
> Since it's desired to return data even if the total size can't be
> updated we need to ignore errors from that fucntion and return plausible

function

> data.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1442344
> ---
> 
> Notes:
>     This function will require more fixing though. This is just a bandaid to
>     remove the regression. I'll post other patches as follow up later.
> 
>  src/qemu/qemu_driver.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 

ACK

John

could have sworn I looked at this late last week and responded to it.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux