On Wed, Apr 26, 2017 at 19:52:41 +0200, Peter Krempa wrote:
> Add possibility to specify one or more cookies for http based disks.
> This patch adds the config parser, storage and validation of the
> cookies.
> ---
> docs/formatdomain.html.in | 9 ++
> docs/schemas/domaincommon.rng | 39 +++++--
> src/conf/domain_conf.c | 108 +++++++++++++++++-
> src/util/virstoragefile.c | 124 +++++++++++++++++++++
> src/util/virstoragefile.h | 14 +++
> .../generic-disk-network-http.xml | 4 +
> 6 files changed, 289 insertions(+), 9 deletions(-)
[...]
>
> @@ -7590,6 +7663,12 @@ virDomainDiskSourceParse(xmlNodePtr node,
>
> if (virDomainStorageHostParse(node, &src->hosts, &src->nhosts) < 0)
> goto cleanup;
> +
> + if (src->protocol == VIR_STORAGE_NET_PROTOCOL_HTTP &&
This is missing "|| src->protocol == VIR_STORAGE_NET_PROTOCOL_HTTPS".
Consider this fixed in the private branch.
> + (tmpnode = virXPathNode("./cookies", ctxt))) {
> + if (virDomainStorageCookiesParse(tmpnode, ctxt, src) < 0)
> + goto cleanup;
> + }
> break;
> case VIR_STORAGE_TYPE_VOLUME:
> if (virDomainDiskSourcePoolDefParse(node, &src->srcpool) < 0)
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
