On Wed, Apr 26, 2017 at 06:13:44PM +0200, Andrea Bolognani wrote:
> [David and Drew added to CC, feel free to skip to the bottom]
>
> On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote:
> [...]
> > + } else if (def->os.arch == VIR_ARCH_AARCH64 &&
> > + virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI)) {
> > + /* If possible use qemu-xhci as default controller for
> > + * aarch64, it's USB3 controller and we want to avoid using
> > + * nec-usb-xhci. */
> > + cont->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_QEMU_XHCI;
>
> If qemu-xhci is not available but usb-nec-xhci is, it would
> probably be nicer to pick the latter rather than leaving it
> unspecified (which will result in an error later on).
This is not true, if the qemu-xhci is not available libvirt will set
piix3-uhci if available as a default for aarch64. Only in case that
piix3-uhci is not available it will fail.
> So I would basically use the same code as ppc64 here, minus
> the pci-ohci part of course.
That should be addressed by a separate patch.
Pavel
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
