Re: [PATCH v2 03/11] secret: Use consistent naming for variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 25, 2017 at 05:15:27PM -0400, John Ferlan wrote:
> When processing a virSecretPtr use 'secret' as a variable name.
> 
> When processing a virSecretObjPtr use 'obj' as a variable name.
> 
> When processing a virSecretDefPtr use 'def' as a variable name,
> unless a distinction needs to be made with a 'newdef' such as
> virSecretObjListAddLocked (which also used the VIR_STEAL_PTR macro
> for the configFile and base64File).
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/conf/virsecretobj.c    | 271 ++++++++++++++++++++++-----------------------
>  src/conf/virsecretobj.h    |  26 ++---
>  src/secret/secret_driver.c | 139 ++++++++++++-----------
>  3 files changed, 223 insertions(+), 213 deletions(-)

This patch has a some unrelated newline changes, that's for a separate patch.

ACK if you remove them.

Pavel

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux