Re: [PATCH 01/15] nwfilter: Use consistent naming for variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 24, 2017 at 03:18:30PM -0400, John Ferlan wrote:
> When processing a virNWFilterPtr use 'nwfilter' as a variable name.
> 
> When processing a virNWFilterObjPtr use 'obj' as a variable name.
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/conf/virnwfilterobj.c      | 92 +++++++++++++++++++++---------------------
>  src/conf/virnwfilterobj.h      |  7 ++--
>  src/nwfilter/nwfilter_driver.c | 78 +++++++++++++++++------------------
>  3 files changed, 89 insertions(+), 88 deletions(-)

I'll just loudly object that this is not necessary but on the other hand
it makes following the code through different functions easier.

Weak ACK, if there are on objections from others.

Pavel

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux