Re: [PATCH 08/14] secret: Change variable names for list traversals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/25/2017 04:47 AM, Pavel Hrdina wrote:
> On Mon, Apr 24, 2017 at 02:00:17PM -0400, John Ferlan wrote:
>> Rather than 'nuuids' it should be 'maxuuids' and rather than 'got'
>> it should be 'nuuids'.  Alter the logic of the list traversal to
>> utilize those names.
>>
>> Also alter the cleanup in virSecretObjListGetUUIDs to return on success
>> and handle failure with a -1 return instead of the if (ret < 0) logic.
> 
> Even this logic change is minimal it's better to have the rename changes
> in a separate commit.

I can split them further before pushing

John

> 
> ACK anyway
> 
> Pavel
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux