On 04/25/2017 04:39 AM, Pavel Hrdina wrote: > On Mon, Apr 24, 2017 at 02:00:16PM -0400, John Ferlan wrote: >> Move code closer to usage. > > NACK, the function is exported so the usage is not only inside this file. > In addition it adds an extra step while tracing the history of the code. > > Pavel > While I don't agree, but I can drop this - again, in patches not yet posted it's a lot easier to read the code with the GetUUIDs closer to what GetHelper (or what it becomes by patch9). John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list