Re: [PATCH v2 01/10] nodedev: Make use of the compile-time missing enum in switch error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 20, 2017 at 03:05:51PM +0200, Erik Skultety wrote:
> So udevGetDeviceDetails was one those functions using an enum in a

s/one those/one of those/

> switch, but since it had a 'default' case, compiler didn't warn about an
> unhandled enum. Moreover, the error about an unsupported device type
> reported in the default case is unnecessary, since by the time we get
> there, udevGetDeviceType (which was called before) already made sure
> that any unrecognized device types had been handled properly.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  src/node_device/node_device_udev.c | 45 +++++++++++++-------------------------
>  1 file changed, 15 insertions(+), 30 deletions(-)

ACK

Pavel

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux