On Wed, Apr 19, 2017 at 08:10:22PM -0400, John Ferlan wrote: > > > On 04/19/2017 06:43 AM, Daniel P. Berrange wrote: > > There are several functions in virshInit which can fail, especially > > when running win32 builds under WINE. Currently virsh just exits > > without reporting what error happened. > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > --- > > tools/virsh.c | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > Why not a "goto error;" instead where error: does the > vshReportError(ctl); return false; > > ACK either way I realize I accidentally pushed this patch already yesterday when pushing the RBD build breaker fix. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
