Re: [PATCH 0/7] storage: Create common virStorageObj* APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/06/2017 01:48 PM, John Ferlan wrote:
Merge code in storage_driver.c and test_driver into virstorageobj to
count the number of volumes/pools, to return a list of names, return
the collected list of objects for volumes/pools. For volumes, that's
moved code, while for pools that's just changing the export API to
take an address of 'devobjs' to follow other usages. I also added
code to converge the FindBy{UUID|Name}

FWIW: This is part of the common driver objects code I've been working
through. I figured I will post each driver separately rather than one

John Ferlan (7):
  storage: Introduce virStoragePoolObjNumOfVolumes
  storage: Introduce virStoragePoolObjVolumeGetNames
  storage: Introduce virStoragePoolObjVolumeListExport
  storage: Introduce virStoragePoolObjNumOfStoragePools
  storage: Introduce virStoragePoolObjGetNames
  storage: Pass driver arg by ref
  storage: Create helpers to perform FindByUUID and FindByName

 src/conf/virstorageobj.c     | 165 +++++++++++++++++++++++-
 src/conf/virstorageobj.h     |  45 ++++++-
 src/libvirt_private.syms     |   5 +
 src/storage/storage_driver.c | 297 +++++++++++++------------------------------
 src/test/test_driver.c       | 131 +++++--------------
 5 files changed, 332 insertions(+), 311 deletions(-)


ACK series, but please do see my comments before pushing - you'll need to fix some nits.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux