Recent change to use virDomainDiskEmptySource broke internal snapshots since the check was not robust enough. While looking at it I found more brokenness. Peter Krempa (5): conf: Keep 'readonly' property when resetting disk source qemu: snapshot: Skip empty drives with internal snapshots qemu: migration: Skip cache=none check for disks which are storage-migrated qemu: migration: Use virStorageSourceIsEmpty in qemuMigrateDisk qemu: migration: Reject migration of an empty disk src/conf/domain_conf.c | 3 +++ src/qemu/qemu_driver.c | 3 ++- src/qemu/qemu_migration.c | 64 ++++++++++++++++++++++++++++------------------- 3 files changed, 43 insertions(+), 27 deletions(-) -- 2.12.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list