Re: [PATCH 4/7] qemu: Move qemuCaps->{kvm, tcg}CPUModel into a struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 07, 2017 at 13:18:53 +0200, Ján Tomko wrote:
> On Fri, Apr 07, 2017 at 01:07:52PM +0200, Jiri Denemark wrote:
> >On Tue, Apr 04, 2017 at 12:34:49 -0400, John Ferlan wrote:
> >>
> >>
> >> On 03/31/2017 01:54 PM, Jiri Denemark wrote:
> >> > We will need to store two more host CPU models and nested structs look
> >> > better than separate items with long complicated names.
> >> >
> >> > Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
> >> > ---
> >> >  src/qemu/qemu_capabilities.c | 65 ++++++++++++++++++++++++++------------------
> >> >  1 file changed, 39 insertions(+), 26 deletions(-)
> >> >
> >>
> >> There's two patches in here... One to have a separate
> >> virQEMUCapsCopyHostCPUData and the other to create the 'hostCPU'
> >
> >Oops, I accidentally pushed this series when I wanted to push the
> >"qemu: Properly reset all migration capabilities" one :-( Are you OK
> >with me sending the additional changes as follow-up patches rather than
> >reverting the patches and pushing the updated ones?
> >
> 
> Reverting the patches and doing them right would IMO look better,
> especially if we ever need to backport them somewhere.

OK, I guess it's probably also going to be easier to make the changes
and review the resulting patches. I've sent the reverts...

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux