Hi, Just to follow up this issue, I haven't found any way to get this info from standard parted :( /Henrik > -----Original Message----- > From: libvir-list-bounces@xxxxxxxxxx > [mailto:libvir-list-bounces@xxxxxxxxxx] On Behalf Of Henrik Persson E > Sent: den 26 juni 2009 12:08 > To: veillard@xxxxxxxxxx > Cc: libvirt-list@xxxxxxxxxx > Subject: RE: [libvirt] [PATCH] Do a correct format mapping of > partitions 2 > > > I checked the SLES package and it is a patch that they have > added themselves :( I will look into it to see if parted > provides a better way to get the same information. > > /Henrik > > > -----Original Message----- > > From: Daniel Veillard [mailto:veillard@xxxxxxxxxx] > > Sent: den 25 juni 2009 16:31 > > To: Henrik Persson E > > Cc: libvirt-list@xxxxxxxxxx > > Subject: Re: [libvirt] [PATCH] Do a correct format mapping of > > partitions 2 > > > > On Tue, Jun 23, 2009 at 12:47:58PM +0200, Henrik Persson wrote: > > > > > > I make a new try from a different mail client now. > > > > Hi Henrik, > > > > Okay, got it but there is a problem: > > > > > + /* Get partition type */ > > > + if(ped_partition_is_active(part)) { > > > + if(ped_partition_is_flag_available(part, > > PED_PARTITION_TYPE)) { > > > + partType = > > ped_partition_get_flag(part,PED_PARTITION_TYPE); > > > + } > > > + } > > > + > > > > paphio:~/libvirt -> grep PED_PARTITION_TYPE /usr/include/parted/*.h > > paphio:~/libvirt -> rpm -qf /usr/include/parted/parted.h > > parted-devel-1.8.8-17.fc11.x86_64 > > > > PED_PARTITION_TYPE is nowhere to be found in my parted headers so > > even if there is a runtime check to see if that flag is > available, it > > just doesn't compile here. I suspect something changed > seriously as I > > can see a reference to PED_PARTITION_TYPE in older version > 1.7.0 maybe > > that's what's you got on SuSE but that flag is not available on > > Fedora, so this would need at least a #ifdef PED_PARTITION_TYPE or > > make sure we use a more stable interface to fetch it, > > > > Could you investigate the issue ? Is there a different > API available > > ? > > > > > > The other parts of the patch looks fine but really depend on being > > able to fetch that information in the first place, so it's > not worth > > applying as is. > > > > Daniel > > > > -- > > Daniel Veillard | libxml Gnome XML XSLT toolkit > > http://xmlsoft.org/ > > daniel@xxxxxxxxxxxx | Rpmfind RPM search engine > http://rpmfind.net/ > > http://veillard.com/ | virtualization library http://libvirt.org/ > > > > -- > Libvir-list mailing list > Libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list > -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list