On Mon, Apr 03, 2017 at 17:03:43 +0200, Andrea Bolognani wrote: > On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote: [...] > > +virstorageutiltest_LDADD = \ > > + ../src/libvirt_driver_storage_impl.la \ > > + $(LDADDS) \ > > + $(NULL) > > + [...] > You should also be able to use $(qemu_LDADDS) instead of > spelling out ../src/libvirt_driver_storage_impl.la above. Yes, but that pulls in all the qemu driver crap, which has no place in a test testing only the storage driver. [...] > > +#undef DO_TEST_GLUSTER_LOOKUP_NATIVE > > +#undef DO_TEST_GLUSTER_LOOKUP_NETFS > > +#undef DO_TEST_GLUSTER_LOOKUP_FULL > > The #undefs are a bit unnecessary in this context, I'd leave > them out. It's true that it would be hard to use these somewhere else (since they are in a .c file) but ad-hoc macros should be undefined. Otherwise they are not ad-hoc and should bear the VIR_ prefix.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
