On Tue, Apr 04, 2017 at 10:52:39 +0100, Daniel Berrange wrote: > On Tue, Apr 04, 2017 at 09:12:11AM +0200, Peter Krempa wrote: > > On Tue, Apr 04, 2017 at 09:05:58 +0200, Ján Tomko wrote: > > > Similar to commit c3c2cc6, use a literal newsline instead of \n > > > inside the brackets. > > > --- > > > Pushed as a build fix. > > > > This is ugly. How about dropping support for platforms which can't use > > new enough libraries rather than band-aiding the code? > > > > Nobody in their right mind would use upstream software with very old > > distros. > > We still target RHEL6 as a platform for libvirt to build on and as such > people reasonably expect tests to pass when built there. It is mildly > ugly but not a serious maint burden to us long term. Yes I know we still target it. That's why I said we should drop it. I don't expect it to happen, but the constant breakages due to symbol shadowing (since gcc is too old) or this bother me. And I actually don't see much use in keeping it. Using upstream libvirt on rhel6 would be insane for a production environment. Using rhel6 for a development environment is insane by itself.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
