On Mon, Apr 03, 2017 at 16:20:26 +0200, Andrea Bolognani wrote: > On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote: > [...] > > @@ -93,6 +93,10 @@ int virStorageBackendDeleteLocal(virConnectPtr conn, > > int virStorageBackendRefreshLocal(virConnectPtr conn, > > virStoragePoolObjPtr pool); > > > > +int virStorageUtilGlusterExtractPoolSources(const char *host, > > + const char *xml, > > + virStoragePoolSourceListPtr list, > > + bool netfs); > > Please add a comment along the lines of "For test suite use > only" here. Ideally we'd have a separate *priv.h header file > to be used for the purpose, but that's out of scope. Why? This function can be used wherever it's necessary. It's by no-means specific to the test suite.
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list