Re: [PATCH 03/11] hyperv: introduce hypervWmiClassInfo struct.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2017-03-30 18:47 GMT+02:00 Dawid Zamirski <dzamirski@xxxxxxxxx>:
> This struct is to be used to carry all the information necessary to
> issue wsman requests for given WMI class. Those will be defined by the
> generator code (as lists) so that they are handy for the driver code to
> "extract" needed info depending on which hyper-v we're connected to.
> For example:
>
> hypervWmiClassInfoListPtr Msvm_ComputerSystem_WmiInfo = {
>     .count = 2
>     {
>         {
>             .name = "Msvm_ComputerSystem",
>             .version = "v1",
>             .rootUri = "http://asdf.com";,
>             ...
>         },
>         {
>             .name = "Msvm_ComputerSystem",
>             .version = "v2",
>             .rootUri = "http://asdf.com/v2";,
>             ...
>         },
>     }
> };
>
> Then the driver code will grab either "v1" or "v2" to pass info wsman
> API, depending on hypervPrivate->wmiVersion value.
> ---
>  src/hyperv/hyperv_wmi.c         |  6 ++----
>  src/hyperv/hyperv_wmi_classes.h | 22 ++++++++++++++++++++++
>  2 files changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c
> index 947101f..309edac 100644
> --- a/src/hyperv/hyperv_wmi.c
> +++ b/src/hyperv/hyperv_wmi.c
> @@ -36,16 +36,14 @@
>
>  #define WS_SERIALIZER_FREE_MEM_WORKS 0
>
> -#define ROOT_CIMV2 \
> +# define ROOT_CIMV2 \
>      "http://schemas.microsoft.com/wbem/wsman/1/wmi/root/cimv2/*";
>
> -#define ROOT_VIRTUALIZATION \
> +# define ROOT_VIRTUALIZATION \
>      "http://schemas.microsoft.com/wbem/wsman/1/wmi/root/virtualization/*";
>
>  #define VIR_FROM_THIS VIR_FROM_HYPERV
>
> -
> -
>  int
>  hypervVerifyResponse(WsManClient *client, WsXmlDocH response,
>                       const char *detail)

Unnecessary whitespace change. Also this will not pass make syntax-check.

I'll drop this complete hunk before pushing it.

-- 
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux