2017-03-30 18:47 GMT+02:00 Dawid Zamirski <dzamirski@xxxxxxxxx>: > Hello, > > The following patch series reworks the hyper-v driver structs and the > code generator to provide seamless support for both Hyper-V 2008 and > 2012 or newer. This does not implement any new libvirt APIs, it just > adapts existing 2008-only driver to also handle 2012 and newer by > sharing as much driver code as possible (currently it's all of it :-)) > This is needed to set the foundation before we can move forward with > implementing the rest of the driver APIs. > > With 2012 release, Microsoft introduced "v2" version of Msvm_* WMI > classes. Those are largely the same as "v1" (used in 2008) but have some > new properties as well as need different wsman request URIs. To > accomodate those differences, most of work went into the code generator > so that it's "aware" of possibility of multiple versions of the same WMI > class and produce C code accordingly. I took a quick look at the series. Overall it looks very good and I like the underlying approach. I'll do a detailed review of it tomorrow. -- Matthias Bolte http://photron.blogspot.com -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list