Re: [PATCH v2 1/5] qemu: Split virQEMUCapsInitArchQMPBasic()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 03/29/2017 10:08 AM, Andrea Bolognani wrote:
> Instead of having a single function that probes the
> architecture from the monitor and then sets a bunch of
> basic capabilities based on it, have a separate function
> for each part: virQEMUCapsInitQMPArch() only sets the
> architecture, and virQEMUCapsInitQMPBasicArch() only sets
> the capabilities.
> 
> This split will be useful later on, when we will want to
> set basic capabilities from the test suite without having
> to go through the pain of mocking the monitor.
> ---
> This is 99% pure code motion; however, an early 'return -1'
> has been converted to the equivalent 'goto cleanup'.
> 
>  src/qemu/qemu_capabilities.c | 42 +++++++++++++++++++++++++++++++-----------
>  1 file changed, 31 insertions(+), 11 deletions(-)
> 

ACK,

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux