On Tue, Mar 28, 2017 at 09:51:22 +0200, Ján Tomko wrote:
> This reverts commit ca4515d2639057020c749470f390fe1f5981e91e
> which broke the functionality of logical storage pools
> not named after their volume groups.
> ---
> src/conf/storage_conf.c | 8 --------
> tools/virsh.pod | 7 -------
> 2 files changed, 15 deletions(-)
>
> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> index 5213503..585ca71 100644
> --- a/src/conf/storage_conf.c
> +++ b/src/conf/storage_conf.c
> @@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt)
> if (VIR_STRDUP(ret->source.name, ret->name) < 0)
> goto error;
> }
> - if (ret->type == VIR_STORAGE_POOL_LOGICAL &&
> - STRNEQ(ret->name, ret->source.name)) {
> - virReportError(VIR_ERR_XML_ERROR,
> - _("for a logical pool, the pool name='%s' "
> - "must match the pool source name='%s'"),
> - ret->name, ret->source.name);
> - goto error;
> - }
This check does not make much sense.
> }
>
> if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) &&
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index 55b71a9..43124ba 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and
> I<--no-overwrite> flags follow the same rules as B<pool-build>. If
> just I<--build> is provided, then B<pool-build> is called with no flags.
>
> -For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>]
The first sentence might make sense, since you don't change the code
that would invalidate it.
> -must match the Volume Group name for which the pool is being defined or
> -created. The [I<--source-name>] if provided must match the Volume Group
This needs to go.
> -name. If not provided, one will be generated using the [I<--name>]. If
> -provided the [I<--target>] is ignored and a target source is generated
> -using the [I<--source-name>] (or as generated from the [I<--name>]).
This might make sense though.
> -
ACK if you don't completely revert the documentation change.
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
