On Tue, Jun 30, 2009 at 04:22:38PM -0400, David Allan wrote:
> * src/storage_driver.c: don't call virStoragePoolObjRemove when a pool create call fails because the pool already exists.
> ---
> src/storage_driver.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/storage_driver.c b/src/storage_driver.c
> index 69dcbda..5a26993 100644
> --- a/src/storage_driver.c
> +++ b/src/storage_driver.c
> @@ -476,6 +476,8 @@ storagePoolCreate(virConnectPtr conn,
> if (pool) {
> virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
> "%s", _("storage pool already exists"));
> + virStoragePoolObjUnlock(pool);
> + pool = NULL;
> goto cleanup;
> }
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list