[...] > +int > +virNumaGetNodeCPUs(int node, virBitmapPtr *cpus) > +{ > + int ret = -1; > + char *cpulist = NULL; > + > + if (virSysfsGetNodeValueString(node, "cpulist", &cpulist) < 0) > + return -1; > + > + *cpus = virBitmapParseUnlimited(cpulist); > + if (!cpus) I think you meant "if (!*cpus)" (Coverity complained about checking for NULL cpus before assigning to it). John > + goto cleanup; > + > + ret = virBitmapCountBits(*cpus); > + cleanup: > + VIR_FREE(cpulist); > + return ret; > +} > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list