Re: [PATCH 16/23] qemu: block: Add code to allow detection of auto-allocated node names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/15/2017 11:37 AM, Peter Krempa wrote:
> qemu for some time already sets node names automatically for the block
> nodes. This patch adds code that attempts a best-effort detection of the
> node names for the backing chain from the output of
> 'query-named-block-nodes'. The only drawback is that the data provided
> by qemu needs to be matched by the filename as seen by qemu and thus
> if two disks share a single backing store file the detection won't work.
> 
> This will allow us to use qemu commands such as
> 'block-set-write-threshold' which only accepts node names.
> 
> In this patch only the detection code is added, it will be used later.
> ---

A bit hairy to follow, but looks like it works. The real test will be
when I play with it after applying your entire series locally, to see
what I can come up with.  So for now, tentative ACK

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]
  Powered by Linux