On 03/15/2017 11:37 AM, Peter Krempa wrote:
> Add code to call the appropriate monitor command and code to lookup the
> given disk backing chain member.
> ---
>
> +
> + if (!src->nodebacking) {
> + virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
> + _("threshold currently can't be set for block device '%s'"),
> + dev);
> + goto endjob;
> + }
So if I'm reading this right, at this point in the series, you always
fail here because src->nodebacking is still not set, but that's what
later patches address.
> static virHypervisorDriver qemuHypervisorDriver = {
> .name = QEMU_DRIVER_NAME,
> .connectOpen = qemuConnectOpen, /* 0.2.0 */
> @@ -20505,6 +20574,7 @@ static virHypervisorDriver qemuHypervisorDriver = {
> .domainGetGuestVcpus = qemuDomainGetGuestVcpus, /* 2.0.0 */
> .domainSetGuestVcpus = qemuDomainSetGuestVcpus, /* 2.0.0 */
> .domainSetVcpu = qemuDomainSetVcpu, /* 3.1.0 */
> + .domainSetBlockThreshold = qemuDomainSetBlockThreshold /* 3.2.0 */
Earlier in 10/23:
+ .domainSetBlockThreshold = remoteDomainSetBlockThreshold, /* 3.1.0 */
You'll want those numbers to match ;)
With that fixed (presumably the typo is in 10/23), ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
